Use microphysics EOS in Quokka's EOS.hpp for all quokka tests + use amu instead of hydrogen mass throughout Quokka #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
This is a linking issue. It looks like the necessary EOS .cpp files aren't being linked into the binary, so these functions don't exist when it tries to link it together. |
|
Hopefully it's just a missing *.cpp file. However, it can be something more exotic, in which case it is unfortunately necessary to understanding how the linker works in some detail. If you are in the latter situation, I would recommend reading this: https://www.lurklurk.org/linkers/linkers.html. |
|
/azp run |
for more information, see https://pre-commit.ci
|
/azp run |
|
Can you add a new *.rst file in Since the rest of us were confused about this on the call, I think new users will be very confused without some documentation. |
|
We don't need |
|
/azp run |
|
No commit pushedDate could be found for PR 324 in repo quokka-astro/quokka |
|
/azp run |
|
this is ready @BenWibking |
|
I'll take a look this afternoon. |
BenWibking
reviewed
Jul 25, 2023
|
Looks good, except for the last remaining Automerge enabled. |
|
This does seem a bit slower than usual. |
Yes, I found that too. I actually commented about it earlier but then edited my comment thinking it was probably a Gadi thingy, because on avatar it doesn't take any longer than before. |
|
/azp run |
|
No commit pushedDate could be found for PR 324 in repo quokka-astro/quokka |
|
/azp run |
|
Ready to be merged @BenWibking |
BenWibking
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@BenWibking , look at this test change I made to
EOS.hpp: for tests other than primordial chem, now, I want to use microphysics EOS toComputeTgasFromEint. I create a burn_t object, add the density, Eint and mean_molecular_weight to it, and then use theeos(eos_input_re, ...)call to find the temperature.While compiling a test that actually uses
ComputeTgasFromEint(e.g., HydroShocktubeCMA), I get these errors:I think the reason behind these errors is that I haven't initialized the microphysics eos and extern_parameters. In primordial chem test, I do
init_extern_parameters()andeos_init()to initialize them. My question is, where should I carry out this initialization for other tests? In their respectivetest.cppfiles? Or, inEOS.hppitself?